Fixing a few things #66

Merged

MCWertGaming merged 16 commits from fixing into main

2022-06-11 18:16:35 +00:00

MCWertGaming commented

2022-06-09 21:08:17 +00:00

(Migrated from github.com)

This PR solves a few issues that are dangling around:

#55: Fixed http code 200 being returned on wrong data
#17: Fixed a bug in the session rotation that leads to overwriting the last session instead of the first
#44: The session TTL is now increased when it's used so the session keeps being valid
#65: Added missing error handling for some functions
#19: Updated the swagger reference with the removed delete endpoint and the new http status code 406 for invalid headers
#39: Added repo files like issue templates

This PR solves a few issues that are dangling around: - #55: Fixed http code 200 being returned on wrong data - #17: Fixed a bug in the session rotation that leads to overwriting the last session instead of the first - #44: The session TTL is now increased when it's used so the session keeps being valid - #65: Added missing error handling for some functions - #19: Updated the swagger reference with the removed delete endpoint and the new http status code 406 for invalid headers - #39: Added repo files like issue templates

JustFoxx (Migrated from github.com) reviewed

2022-06-09 21:08:17 +00:00

FissionFeline (Migrated from github.com) reviewed

2022-06-09 21:08:17 +00:00

Sigmanificient (Migrated from github.com) requested changes

2022-06-09 21:37:50 +00:00

README.md

Sigmanificient (Migrated from github.com) commented

2022-06-09 21:36:13 +00:00

Why this is not handled within a .env file?

Why this is not handled within a `.env` file?

internal/helper/session.go

Sigmanificient (Migrated from github.com) commented

2022-06-09 21:37:31 +00:00

This contains a lot of code repetition, there is surely a better to handle the session

FissionFeline (Migrated from github.com) reviewed

2022-06-09 21:41:50 +00:00

MCWertGaming (Migrated from github.com) reviewed

2022-06-09 22:21:11 +00:00

README.md

MCWertGaming (Migrated from github.com) commented

2022-06-09 22:21:11 +00:00

because authfox will run in a docker container in production, allowing users to use a .env file for development would mean extra code that is not necessary. So I guess that a better approach would be automating the configuration of the development environment set up, like visual studio code container work spaces (which would also handle the DB setup so people not even have to run the docker compose file for quickly getting started). It's tracked in #45.